refactor(admin_audit): improve type safety and clarity in Action logging#57315
Draft
joshtrichards wants to merge 2 commits intomasterfrom
Draft
refactor(admin_audit): improve type safety and clarity in Action logging#57315joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
ActionThe original implementation had several edge cases that could produce unclear audit logs:
falsevalues appeared as empty strings (invisible in logs)$elements,$text) didn't clearly convey their purposeThis refactoring makes the audit logging more defensive, maintainable, and produces clearer output for security auditing purposes.
TODO
Checklist
3. to review, feature component)stable32)