feat(sharing): remove share permission from "Allow editing" default #57631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
artonge,
susnux and
szaimen
and removed request for
a team
nfebe
added
feature: sharing
pending documentation
susnux
approved these changes
Jan 19, 2026
Contributor
Author
|
/compile |
nfebe
force-pushed
the
fix/remove-share-permission-from-allow-editing
branch
from
02787b3 to
1ed5d6a
Compare
Contributor
Author
|
/compile / |
nfebe
force-pushed
the
fix/remove-share-permission-from-allow-editing
branch
from
32c397e to
77de5d4
Compare
Contributor
Author
|
/compile / |
nfebe
force-pushed
the
fix/remove-share-permission-from-allow-editing
branch
from
7713abf to
168ca4a
Compare
Contributor
Author
|
/compile / |
marcoambrosini
approved these changes
Jan 20, 2026
kra-mo
approved these changes
Jan 20, 2026
nfebe
force-pushed
the
fix/remove-share-permission-from-allow-editing
branch
from
013e710 to
1a0943c
Compare
Contributor
Author
|
/compile / |
Remove PERMISSION_SHARE from bundled permissions for ALL and ALL_FILE. Update quick share selector to consistently strip share permission when comparing, ensuring backwards compatibility with existing shares. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Handle backward compatibility when config.defaultPermissions includes the SHARE permission (value 31) which was previously part of BUNDLED_PERMISSIONS.ALL. Now that ALL no longer includes SHARE, the comparison must strip SHARE before checking against bundled permissions. This fixes an issue where the Advanced Settings section would be auto-expanded for new shares, causing a toggle to close it instead of opening it. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/remove-share-permission-from-allow-editing
branch
from
ca68b1b to
cb0f011
Compare
Contributor
Author
|
/compile / |
Tests that access elements inside the Advanced Settings section (hide download, share label, grid view, etc.) must first click "Advanced settings" to expand it. Previously these tests relied on buggy auto-expand behavior that occurred when permissions didn't match bundled values. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/remove-share-permission-from-allow-editing
branch
from
cb0f011 to
80ab683
Compare
Contributor
Author
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PERMISSION_SHARE from bundled permissions for ALL and ALL_FILE. Update quick share selector to consistently strip share permission when comparing, ensuring backwards compatibility with existing shares.