Skip to content

Fix incorrect user count#57736

Open
Sebastianmueller22 wants to merge 2 commits intonextcloud:masterfrom
Sebastianmueller22:fix-incorrect-user-count
Open

Fix incorrect user count#57736
Sebastianmueller22 wants to merge 2 commits intonextcloud:masterfrom
Sebastianmueller22:fix-incorrect-user-count

Conversation

@Sebastianmueller22
Copy link

Summary

Just a simple check if the limit is exceeded it adds a plus. Tested with a system with that many users in a subgroup and it showed up correctly.

Resolves #54878

Checklist

Signed-off-by: Sebastian Mueller <muellersebastian@mail.com>
Signed-off-by: Sebastian Mueller <muellersebastian@mail.com>
@Sebastianmueller22 Sebastianmueller22 requested a review from a team as a code owner January 22, 2026 16:21
@Sebastianmueller22 Sebastianmueller22 requested review from ArtificialOwl, CarlSchwan, icewind1991 and salmart-dev and removed request for a team January 22, 2026 16:21


// display user count with a plus appended, if limit is exceeded
$userCount = ($userCount < self::COUNT_LIMIT_FOR_SUBADMINS) ? $userCount : self::COUNT_LIMIT_FOR_SUBADMINS . '+';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the return type in the frontend, not sure what are the consequence of that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't produce any issue in my test. I looked for usages and it seems to be handled in a type agnostic way. I did it in oder to not have the limit hard coded in the frontend as well.

I could alternatively send the limit with the response and make the check in the frontend. Should I do that instead?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Display to "999+" when users limit is reached in Accounts

2 participants

Comments