Fix incorrect user count#57736
Conversation
Signed-off-by: Sebastian Mueller <muellersebastian@mail.com>
Signed-off-by: Sebastian Mueller <muellersebastian@mail.com>
|
|
||
|
|
||
| // display user count with a plus appended, if limit is exceeded | ||
| $userCount = ($userCount < self::COUNT_LIMIT_FOR_SUBADMINS) ? $userCount : self::COUNT_LIMIT_FOR_SUBADMINS . '+'; |
There was a problem hiding this comment.
This will change the return type in the frontend, not sure what are the consequence of that
There was a problem hiding this comment.
It didn't produce any issue in my test. I looked for usages and it seems to be handled in a type agnostic way. I did it in oder to not have the limit hard coded in the frontend as well.
I could alternatively send the limit with the response and make the check in the frontend. Should I do that instead?
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Just a simple check if the limit is exceeded it adds a plus. Tested with a system with that many users in a subgroup and it showed up correctly.
Resolves #54878
Checklist
3. to review, feature component)stable32)