-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore: remove X from social links #57798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable33 |
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There is still a link to twitter.com in the README and I also found "View %s on Twitter" as a string in the translations, but not the source code (that's probably because it still exists on some stable branch?).
|
/backport to stable32 |
|
/backport to stable31 |
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but did not test
Nextcloud does not use X anymore. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57798/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 60b6e834
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57798/stable33Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/57798/stable33."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Nextcloud does not use X anymore.
Checklist
3. to review, feature component)stable32)