Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 26, 2026

Summary

Nextcloud does not use X anymore.

Checklist

@susnux susnux requested a review from a team as a code owner January 26, 2026 01:05
@susnux susnux requested review from ArtificialOwl, come-nc, leftybournes and salmart-dev and removed request for a team January 26, 2026 01:05
@susnux susnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 26, 2026
@susnux susnux added this to the Nextcloud 34 milestone Jan 26, 2026
@susnux susnux requested review from a team and provokateurin and removed request for a team January 26, 2026 01:05
@susnux
Copy link
Contributor Author

susnux commented Jan 26, 2026

/backport to stable33

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

There is still a link to twitter.com in the README and I also found "View %s on Twitter" as a string in the translations, but not the source code (that's probably because it still exists on some stable branch?).

@provokateurin
Copy link
Member

/backport to stable32

@provokateurin
Copy link
Member

/backport to stable31

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but did not test

Nextcloud does not use X anymore.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from provokateurin January 26, 2026 12:23
@susnux susnux merged commit a93ada7 into master Jan 26, 2026
176 of 178 checks passed
@susnux susnux deleted the fix/remove-x branch January 26, 2026 13:02
@susnux
Copy link
Contributor Author

susnux commented Jan 26, 2026

/backport to stable33

@backportbot
Copy link

backportbot bot commented Jan 26, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/57798/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 60b6e834

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57798/stable33

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/57798/stable33."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove link to X from personal settings

5 participants