fix(systemtags): Correct the return type of system tag object mapper #57820
+46
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
Altahrim
approved these changes
Jan 26, 2026
come-nc
approved these changes
Jan 26, 2026
CarlSchwan
force-pushed
the
carl/fix-return-type-systemtagobjectmapper
branch
from
fe346c0 to
190f207
Compare
cristianscheid
approved these changes
Jan 26, 2026
Currently, it is documented in some places as returning a string but returns a int or a string depending on the database used. This then breaks then using strict comparaison in nextcloud/approval#362 Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/fix-return-type-systemtagobjectmapper
branch
3 times, most recently
from
190f207 to
2d648e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, it is documented in some places as returning a string but returns a int or a string depending on the database used.
This then breaks then using strict comparaison in nextcloud/approval#362
Checklist
3. to review, feature component)stable32)