fix(config): update lazy status using lexicon on hasKey()#58007
Open
ArtificialOwl wants to merge 1 commit intomasterfrom
Open
fix(config): update lazy status using lexicon on hasKey()#58007ArtificialOwl wants to merge 1 commit intomasterfrom
ArtificialOwl wants to merge 1 commit intomasterfrom
Conversation
ArtificialOwl
requested review from
CarlSchwan,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
ArtificialOwl
force-pushed
the
fix/noid/haskey-uses-lexicon
branch
from
75b1ba9 to
a149e78
Compare
ArtificialOwl
force-pushed
the
fix/noid/haskey-uses-lexicon
branch
from
a149e78 to
8fd9a32
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/haskey-uses-lexicon
branch
from
8fd9a32 to
3d42bd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get lazy status from Config Lexicon when calling hasKey():
The method
matchAndApplyLexiconDefinition()references$lazyand will update its value based on Lexicon, if available.With this PR, the hasKey() can be called without specifying the lazyness of the config key