fix(comments): properly handle opening the sidebar when Activity integration is used #58287
+37
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration is used When the activity integration is used we need to open the `activity` tab not the comments tab. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
This fixes invalid error messages if the action has an empty displayname, often the case for inline actions Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
CarlSchwan
approved these changes
Feb 12, 2026
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/58287/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cd15bb06 f2574fdf eb07c52f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58287/stable33Error: Failed to push branch backport/58287/stable33: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the activity integration is used we need to open the
activitytab not the comments tab.Checklist
3. to review, feature component)stable32)