fix: remove user part only at the beginning of path#58338
Open
salmart-dev wants to merge 1 commit intomasterfrom
Open
fix: remove user part only at the beginning of path#58338salmart-dev wants to merge 1 commit intomasterfrom
salmart-dev wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Contributor
Author
|
/backport to stable33 |
salmart-dev
requested review from
ArtificialOwl,
CarlSchwan,
come-nc and
icewind1991
and removed request for
a team
provokateurin
requested changes
Feb 16, 2026
Comment on lines
+873
to
+875
| if (str_starts_with($path, '/' . $userId . '/files')) { | ||
| $path = substr($path, strlen('/' . $userId . '/files')); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (str_starts_with($path, '/' . $userId . '/files')) { | |
| $path = substr($path, strlen('/' . $userId . '/files')); | |
| } | |
| $prefix = '/' . $userId . '/files'; | |
| if (str_starts_with($path, $prefix)) { | |
| $path = substr($path, strlen($prefix)); | |
| } |
To avoid that they get out-of-sync accidentally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #58333 in server share provider
Replaces
str_replacewith astr_starts_with+substrfor stripping the user portion off the path.Checklist
3. to review, feature component)stable32)