feat(DB): Add ITypedQueryBuilder#58373
Merged
provokateurin merged 2 commits intomasterfrom Feb 24, 2026
Merged
Conversation
provokateurin
requested review from
CarlSchwan,
ChristophWurst,
come-nc and
nickvergessen
provokateurin
added
enhancement
3. to review
provokateurin
requested review from
Altahrim and
icewind1991
and removed request for
a team
provokateurin
added
the
pending documentation
provokateurin
force-pushed
the
feat/db/typed-query-builder
branch
from
6199c74 to
3240224
Compare
provokateurin
commented
Feb 17, 2026
provokateurin
commented
Feb 20, 2026
CarlSchwan
approved these changes
Feb 20, 2026
come-nc
reviewed
Feb 23, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Can you give more details on why this is not possible directly in IQueryBuilder, and why the split between selectColumn and selectAlias is needed?
Member
Author
|
The problem is that |
provokateurin
force-pushed
the
feat/db/typed-query-builder
branch
from
3240224 to
c34f819
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/db/typed-query-builder
branch
from
c34f819 to
161c91e
Compare
icewind1991
approved these changes
Feb 24, 2026
Member
Author
provokateurin
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's not possible to infer the column types in the query builder for static analysis, this at least makes the column names available, which will already provide a lot more safety than we currently have. This way it is still necessary to cast columns, but at least psalm will be able to warn about columns that weren't selected.