fix(SetupChecks): update Serverid info level (fallback in use) message#58578
Open
joshtrichards wants to merge 1 commit intomasterfrom
Open
fix(SetupChecks): update Serverid info level (fallback in use) message#58578joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Context: This will be the default behavior and visible message to any instance upgraded from <v33. Builds on #58577 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
ArtificialOwl
and removed request for
a team
Member
Author
|
/backport to stable33 |
rakekniven
approved these changes
Feb 25, 2026
Contributor
|
Could we also document |
Altahrim
reviewed
Feb 26, 2026
Comment on lines
+44
to
+47
| 'The ``serverid`` parameter is not configured. ' | ||
| . 'By default, Nextcloud uses a fallback based on the server hostname. ' | ||
| . 'The fallback suggests a standalone setup, which is generally safe if your configuration will remain on a single server and never be cloned, migrated, or scaled out. ' | ||
| . 'However, if you are running Nextcloud on multiple servers, sharing ``config.php``, or you plan to expand your setup in the future, you should explicitly set a unique integer ``serverid`` (0–1023) for each server. ' |
Collaborator
There was a problem hiding this comment.
Apart from mixed indentation, we can assume fallback is safe for standalone setup (even if hostname change).
I also think the share of config.php is confusing. If it's shared it means several servers are parts of the same instance and you fall in multiple servers, no?
Suggested change
| 'The ``serverid`` parameter is not configured. ' | |
| . 'By default, Nextcloud uses a fallback based on the server hostname. ' | |
| . 'The fallback suggests a standalone setup, which is generally safe if your configuration will remain on a single server and never be cloned, migrated, or scaled out. ' | |
| . 'However, if you are running Nextcloud on multiple servers, sharing ``config.php``, or you plan to expand your setup in the future, you should explicitly set a unique integer ``serverid`` (0–1023) for each server. ' | |
| 'The ``serverid`` parameter is not configured. ' | |
| . 'By default, Nextcloud uses a fallback based on the server hostname. ' | |
| . 'The fallback is safe for a standalone setup.' | |
| . 'However, if you are running Nextcloud on multiple servers, you plan to expand your setup in the future, or simply want to suppress this message, you should explicitly set a unique integer ``serverid`` (0–1023) for each server. ' |
Collaborator
|
And yes, it would be better to detect distributed setups, but I don't have a good way to do this :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context: This will be the default behavior and visible message to any instance upgraded from <v33. It should be as clear as possible.
Builds on #58577
Aside: I wish we could either auto-generate safely in all cases or detect distributed vs standalone setups. The end result is people are going to constantly complain this is visible in their setup checks or they're going to grumble they have to manually set this even though they're on a standalone deployment just to get rid of the setup check info message. I don't have a solution; just noting. ;-)
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)