fix(dav): add missing search_supports_creation_time and search_supports_upload_time to Capabilities return type#58699
Merged
miaulalala merged 1 commit intomasterfrom Mar 3, 2026
Conversation
cristianscheid
requested review from
Altahrim,
artonge,
nfebe and
salmart-dev
and removed request for
a team
cristianscheid
force-pushed
the
fix/noid/dav-capabilities-psalm-return-type
branch
from
31fc148 to
29d98bc
Compare
cristianscheid
force-pushed
the
fix/noid/dav-capabilities-psalm-return-type
branch
2 times, most recently
from
dcf5d04 to
1267e31
Compare
…ts_upload_time to Capabilities return type Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/noid/dav-capabilities-psalm-return-type
branch
from
1267e31 to
80184b4
Compare
miaulalala
approved these changes
Mar 3, 2026
joshtrichards
approved these changes
Mar 3, 2026
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
This will need backporting too, at least if the failed backports on #58562 are dealt with. ;-)
Contributor
Author
@joshtrichards For stable33 this backport should fix it: #58694. I've adjusted it to avoid the psalm errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix psalm error by adding missing search_supports_creation_time and search_supports_upload_time to Capabilities return type
Follow-up to #58562
Checklist
3. to review, feature component)stable32)AI (if applicable)