feat(core): cast valid booleans when setting system configs#58868
feat(core): cast valid booleans when setting system configs#58868
Conversation
come-nc
left a comment
There was a problem hiding this comment.
But that would mean when setting a configuration to "false" or "true" it would automagically decide that it’s a boolean even if we indicated type string?
That seems dangerous to me.
Maybe output a warning but do not change the type on the fly.
Otherwise how would one set a configuration to the string "true", it would not be possible anymore?
We do not have any |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
cee3001 to
d26bf95
Compare
artonge
left a comment
There was a problem hiding this comment.
I just saw that Côme had the same comment. Given your answer, I say let's go!
I think we could be smarter with primitive values like those 🙈
Checklist
3. to review, feature component)stable32)AI (if applicable)