[stable32] Fix federated reshares#58900
Open
backportbot[bot] wants to merge 2 commits intostable32from
Open
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
…r might on another server Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
backport/58689/stable32
branch
from
4127da0 to
d377b66
Compare
provokateurin
approved these changes
Mar 17, 2026
salmart-dev
reviewed
Mar 17, 2026
| * Remove share from table. | ||
| */ | ||
| private function removeShareFromTableById($shareId) { | ||
| public function removeShareFromTable(string $shareId): void { |
Contributor
There was a problem hiding this comment.
$shareId here is always an int as the Snowflake changes are not present on 32 and getLastInsertId returns an int.
salmart-dev
requested changes
Mar 17, 2026
Contributor
salmart-dev
left a comment
salmart-dev
left a comment
There was a problem hiding this comment.
Just a small patch needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58689
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.