Open
Conversation
miaulalala
requested review from
ArtificialOwl,
artonge,
Copilot,
icewind1991,
leftybournes and
skjnldsv
and removed request for
a team
and allow regular cypress tests to run on forks (no secret leaked) add consistent gating for changes remove empty matrix option skip performance workflow on forks without it looking like it's failing Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
chore/noid/update-workflows
branch
from
cf40a66 to
a77040f
Compare
provokateurin
requested changes
Mar 12, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
There are a lot of unrelated changes. Please only remove the cypress cloud stuff and move everything else to another PR.
Contributor
Author
not unrelated, should ideally change my commit message. Making CI work reliably for contributor as well as members is the goal here, of which cypress cloud is only one part. |
Member
|
At least split them up into separate commits with useful commit messages. If I can't understand the CI changes, I won't approve 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
autocheckers.ymlneeds: changes+if: needs.changes.outputs.src != 'false'; fixed summary condition logiccommand-pull-3rdparty.ymlpull-requests: readpermission + GitHub API step for PR metadata; simplifiedserver_refstepcypress.ymlgroup,ci-build-id,tag,CYPRESS_RECORD_KEY)files-external-sftp.ymlsudo chown -R 0777→sudo chmod -R 0777integration-dav.ymlintegration-s3-primary.ymlsleep 10before S3 health checklint-php-cs.ymlneeds: changes+if:guardlint-stylelint.ymlchangesjob viadorny/paths-filter; gatedlinton it; addedsummaryjob for branch protectionnode-test.ymlobject-storage-s3.ymlsleep 10before S3 health checkperformance.ymlif:→ cleanskippedstatus on forksphpunit-object-store-primary.yml--log-junit junit.xmlto PHPUnit runupdate-min-supported-desktop.yml${{ matrix.branches }}-prefix)Checklist
Tests (unitintegration, api and/or acceptance) are includedScreenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not requiredBackports requested where applicable (ex: critical bugfixes)Labels added where applicable (ex: bug/enhancement,3. to review, feature component)stable32)AI (if applicable)