Add optional top bar date/time with personal visibility toggle#58948
Add optional top bar date/time with personal visibility toggle#58948Zhey-on wants to merge 1 commit intonextcloud:masterfrom
Conversation
04cfd60 to
654dee9
Compare
| <span v-if="enabled" class="header-date-time" :title="localizedDateTime"> | ||
| {{ localizedDateTime }} | ||
| </span> |
There was a problem hiding this comment.
Should rather just use NcDateTime from nextcloud-vue
| <script lang="ts"> | ||
| import { defineComponent } from 'vue' | ||
|
|
||
| export default defineComponent({ |
There was a problem hiding this comment.
new files should - if possible - use script setup syntax to be future proof
| </ul> | ||
| </NcHeaderMenu> | ||
| <div class="account-menu-wrapper"> | ||
| <HeaderDateTime :enabled="showHeaderDateTime" /> |
There was a problem hiding this comment.
I do not think this belongs to the account menu
There was a problem hiding this comment.
how are those changes related?
|
Thank you for your contribution! Could you please add screen shots so we can get a review of the @nextcloud/designers to decide if this is something we want to have in the product :) |
|
I don't think we want this from a design POV. Every operating system already has a way to show the date and time in their own bar. The dashboard? Sure, maybe. It has the advantage of potentially actually being front-and-center unlike the time from the OS. But this seems borderline useless. |
I agree as in the dashboard we could then also show timezone offset (e.g. if you are on a public device where local time is 10 am but in Nextcloud you configured a timezone so its 11am.). |
Summary
Fixes #38726.
This adds an optional date and time label in the top bar next to the account menu.
This is intentionally not a dashboard widget.
Users can enable or disable it from Personal settings > Appearance and accessibility settings, under a new Visibility options switch.
What changed
Testing