Skip to content

fix(files): preserve destination path for dropped directories#58951

Open
Zhey-on wants to merge 1 commit intonextcloud:masterfrom
Zhey-on:fix/58760-dropservice-subdirectory-404
Open

fix(files): preserve destination path for dropped directories#58951
Zhey-on wants to merge 1 commit intonextcloud:masterfrom
Zhey-on:fix/58760-dropservice-subdirectory-404

Conversation

@Zhey-on
Copy link

@Zhey-on Zhey-on commented Mar 14, 2026

Summary

Dropping a folder into a subdirectory was creating missing directories with a path that did not include the destination folder.

In practice, that sent WebDAV requests to the wrong location and produced PROPFIND 404 / PUT 404 for nested folder uploads.

This change keeps directory creation anchored to destination.path, so folder drops into subdirectories stay in the selected target.

I also added a regression test that verifies nested directories are created under the destination path.

TODO

  • Add regression test coverage for nested directory drops into a subdirectory target
  • Run post-fix manual checks in the browser (drag/drop into root and into nested subdirectories, then confirm no DAV 404 in logs)

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Zhey <anpropagate@aol.com>
@Zhey-on Zhey-on requested review from a team and skjnldsv as code owners March 14, 2026 21:35
@Zhey-on Zhey-on requested review from nfebe and szaimen and removed request for a team March 14, 2026 21:35
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure this is already fixed with #58680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DropService subdirectory 404

2 participants