refactor(setup): Untangle the collision-avoidance loops for database user creation (MySQL and PostgreSQL)#59094
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
refactor(setup): Untangle the collision-avoidance loops for database user creation (MySQL and PostgreSQL)#59094joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
…() helpers Signed-off-by: Josh <josh.t.richards@gmail.com>
…ame() helper Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: install and update
technical debt
joshtrichards
requested review from
ArtificialOwl,
CarlSchwan,
leftybournes,
nickvergessen and
provokateurin
and removed request for
a team
joshtrichards
changed the title
joshtrichards
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userExists()andfindAvailableUsername()helpers for unity between MySQL and PostgreSQLuserExists()now takes a$usernameparameter instead of implicitly reading from$this->dbUser, avoiding unnecessary mutation infindAvailableUsername()and pulling assignments out of loop bodies for improved readability.Related: #59092
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)