fix(sharing): Surface specific error message on share update failure#59114
Open
fix(sharing): Surface specific error message on share update failure#59114
Conversation
InvalidArgumentException from the share manager (e.g. "Cannot enable sending the password by Talk with an empty password") was caught by the generic Exception handler and re-thrown as "Failed to update share.", hiding the actual cause from the user. Catch it separately to preserve the original message. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan,
artonge,
icewind1991,
provokateurin,
skjnldsv,
sushidave and
szaimen
and removed request for
a team
Contributor
|
Hi @nfebe is there a test plan available before and after what this fixes? |
Contributor
But the message is not localized and should not shown to the user anyways? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvalidArgumentException from the share manager (e.g. "Cannot enable sending the password by Talk with an empty password") was caught by the generic Exception handler and re-thrown as "Failed to update share.", hiding the actual cause from the user. Catch it separately to preserve the original message.