Skip to content

feat(settings): Log AI config changes to audit log#59218

Merged
provokateurin merged 3 commits intomasterfrom
feat/audit-log-ai-config-changes
Mar 26, 2026
Merged

feat(settings): Log AI config changes to audit log#59218
provokateurin merged 3 commits intomasterfrom
feat/audit-log-ai-config-changes

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Mar 26, 2026

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@marcelklehr marcelklehr added this to the Nextcloud 34 milestone Mar 26, 2026
@marcelklehr marcelklehr requested a review from a team as a code owner March 26, 2026 09:48
@marcelklehr marcelklehr added the 3. to review Waiting for reviews label Mar 26, 2026
@marcelklehr marcelklehr requested review from ArtificialOwl, come-nc, provokateurin and salmart-dev and removed request for a team March 26, 2026 09:48
@marcelklehr marcelklehr force-pushed the feat/audit-log-ai-config-changes branch 2 times, most recently from a8541c1 to dc8409d Compare March 26, 2026 09:49
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the feat/audit-log-ai-config-changes branch from dc8409d to 7fe3d1c Compare March 26, 2026 09:50
@marcelklehr marcelklehr changed the title fix(settings): Log AI config changes to audit log feat(settings): Log AI config changes to audit log Mar 26, 2026
@marcelklehr
Copy link
Member Author

/backport to stable33

@marcelklehr
Copy link
Member Author

/backport to stable32

… fails

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller can return a 400 even if some values were actually changed.
Could we first validate all the values and only store them if everything is fine?

Otherwise, lgtm

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr requested a review from julien-nc March 26, 2026 10:32
@provokateurin provokateurin merged commit 7e9e126 into master Mar 26, 2026
189 of 193 checks passed
@provokateurin provokateurin deleted the feat/audit-log-ai-config-changes branch March 26, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants