fix(metrics): sanitize label names in OpenMetrics output#59255
Open
moktamd wants to merge 1 commit intonextcloud:masterfrom
Open
fix(metrics): sanitize label names in OpenMetrics output#59255moktamd wants to merge 1 commit intonextcloud:masterfrom
moktamd wants to merge 1 commit intonextcloud:masterfrom
Conversation
Replace non-alphanumeric characters (e.g. hyphens) in metric label names with underscores so the output conforms to the OpenMetrics specification. Apps like 'hide-photos' produced invalid label names that caused Prometheus ingestion failures.
moktamd
requested review from
ArtificialOwl,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59247
Apps with hyphens in their name (e.g.
hide-photos) produce invalid OpenMetrics label names, causing Prometheus to reject the entire scrape. Label names must match[a-zA-Z_][a-zA-Z0-9_]*per the spec.Sanitizes label names in
formatLabels()by replacing non-alphanumeric characters with underscores, sohide-photosbecomeshide_photos.