ci: centralize path filtering across workflows#59326
Draft
joshtrichards wants to merge 4 commits into
Draft
Conversation
…r logic
Centralize filtering ("changes") logic for maintainability and consistency:
- One shared detect-changes job per workflow run, called via workflow_call
- Single source of truth for "what counts as a PHP change" and "what counts as a JS change"
- Adding a new path = editing 1 file
- Consistent behavior across all "like" workflows
- Paves the way to later adding centralized orchestration (i.e. fewer jobs/duplicate work across workflows triggered by the same change)
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…filter Also an example of how to use a workflow-level `extra-changes` to add workflow-level customized filtering where needed/desirable. Signed-off-by: Josh <josh.t.richards@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change centralizes CI path filtering so workflows can share one filtering implementation instead of duplicating file-matching logic.
This reduces maintenance overhead, improves consistency between workflows, and helps avoid running CI jobs when a changeset does not affect them.
This can be used for all workflows that currently use (or will use)
changesjobs to do path filtering. Today that is ~30 files where this logic is currently distributed around.Instead of doing all 30 at once, this migrates a straightforward variation of each one supported type (PHP, JS, PHP+Custom) -- using the newly introduced re-usable central workflow. This keeps the PR easier to review. Once this passes well, the other ~27 can be done in a single follow-up PR.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)