Skip to content

fix(settings): Don't register invalid routes#59394

Merged
nickvergessen merged 1 commit intomasterfrom
bugfix/noid/dont-register-invalid-routes
Apr 2, 2026
Merged

fix(settings): Don't register invalid routes#59394
nickvergessen merged 1 commit intomasterfrom
bugfix/noid/dont-register-invalid-routes

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

Before

| settings.authsettings.create                              | POST                   | /settings/personal/authtokens                                                         |
| settings.authsettings.destroy                             | DELETE                 | /settings/personal/authtokens/{id}                                                    |
| settings.authsettings.index                               | GET                    | /settings/personal/authtokens                                                         |
| settings.authsettings.show                                | GET                    | /settings/personal/authtokens/{id}                                                    |
| settings.authsettings.update                              | PUT                    | /settings/personal/authtokens/{id}                                                    |
| settings.authsettings.wipe                                | POST                   | /settings/personal/authtokens/wipe/{id}                                               |

💥

class AuthSettingsController extends Controller {
does not have index or show methods

Resulting in log spam on invalid requests:

GET /settings/personal/authtokens/foobar

> Method OCA\Settings\Controller\AuthSettingsController::show() does not exist 

After

| settings.authsettings.create                              | POST                   | /settings/personal/authtokens                                                         |
| settings.authsettings.destroy                             | DELETE                 | /settings/personal/authtokens/{id}                                                    |
| settings.authsettings.update                              | PUT                    | /settings/personal/authtokens/{id}                                                    |
| settings.authsettings.wipe                                | POST                   | /settings/personal/authtokens/wipe/{id}                                               |

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 34 milestone Apr 2, 2026
@nickvergessen nickvergessen requested a review from a team as a code owner April 2, 2026 07:34
@nickvergessen nickvergessen requested review from Altahrim and ArtificialOwl and removed request for a team April 2, 2026 07:34
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Apr 2, 2026
@nickvergessen
Copy link
Copy Markdown
Member Author

/backport to stable33

@nickvergessen nickvergessen self-assigned this Apr 2, 2026
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen nickvergessen merged commit 95e9455 into master Apr 2, 2026
178 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/dont-register-invalid-routes branch April 2, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants