feat: add config header and tests.#59462
Conversation
Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <es-github@rosenberg.org.il>
|
Tagging: @provokateurin @miaulalala |
come-nc
left a comment
There was a problem hiding this comment.
Please use a constant in the test instead of copy/pasting the comment multiple times.
Ideally, you can even have the comment in a public const in Config and use it in the test, so that if we change it later the test does not need to be changed.
|
@come-nc thanks for the feedback! |
|
Or should it just be part of the Class? |
|
A public const in Config class is enough I think |
Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <es-github@rosenberg.org.il>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
config.phpis re-rendered by nextcloud regularly removing comments and rendering constants into their values, nextcloud supports using multiple config files and renders their content into the main config.php without modifying the external files.This PR adds a header to
config.phpwarning the admin/user of this and suggesting the use of the multiple config files mechanism.TODO
config.phpin the order that they were included will probably help admins troubleshoot if a config variable is doubled up by mistake.Checklist
Screenshots before/after for front-end changesBackports requested where applicable (ex: critical bugfixes)3. to review, feature component)stable32)AI (if applicable)
The content of this PR was partly or fully generated using AI