fix(notifications): Require absolute links for support of desktop and mobile clients#59606
Merged
nickvergessen merged 1 commit intomasterfrom Apr 13, 2026
Conversation
… mobile clients Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ArtificialOwl
and removed request for
a team
nickvergessen
requested review from
icewind1991,
leftybournes and
provokateurin
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
provokateurin
approved these changes
Apr 13, 2026
Antreesy
approved these changes
Apr 13, 2026
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
LGTM
How the thrown error is handled? Do we see it in logs, or it goes silent?
Member
Author
Like with all other cases of invalid data being provided. It should be an error in the log at the end but the notification will be hidden |
nickvergessen
deleted the
bugfix/noid/require-absolute-links-in-notifications
branch
miaulalala
added a commit
to nextcloud/activity
that referenced
this pull request
Apr 14, 2026
…P(S) Ensure links and icons passed from activity events to INotification are always absolute HTTP(S) URLs. Relative paths are resolved via IURLGenerator::getAbsoluteURL(), and non-HTTP(S) schemes (e.g. javascript:, nc://, data:) are rejected entirely. This aligns with the stricter validation introduced in nextcloud/server#59606. AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
added a commit
to nextcloud/activity
that referenced
this pull request
Apr 14, 2026
… mobile clients To align with the stricter validation introduced in nextcloud/server#59606. AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
added a commit
to nextcloud/activity
that referenced
this pull request
Apr 14, 2026
… mobile clients To align with the stricter validation introduced in nextcloud/server#59606. AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
added a commit
to nextcloud/activity
that referenced
this pull request
Apr 15, 2026
… mobile clients To align with the stricter validation introduced in nextcloud/server#59606. AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)AI (if applicable)