Skip to content

[stable33] fix(sharing): Don't give a reason when share from disabled user is no… #59612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Apr 13, 2026
+2 −2
Merged

[stable33] fix(sharing): Don't give a reason when share from disabled user is no… #59612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Share20/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ private function checkShare(IShare $share, int &$added = 1): void {
foreach ($uids as $uid) {
$user = $this->userManager->get($uid);
if ($user?->isEnabled() === false) {
throw new ShareNotFound($this->l->t('The requested share comes from a disabled user'));
throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/Share20/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3304,7 +3304,7 @@ public function testGetShareByTokenWithException(): void {

public function testGetShareByTokenHideDisabledUser(): void {
$this->expectException(ShareNotFound::class);
$this->expectExceptionMessage('The requested share comes from a disabled user');
$this->expectExceptionMessage('The requested share does not exist anymore');

$this->config
->expects($this->exactly(2))
Expand Down
Loading