fix(Color): blueF() to return correct channel and tighten validation/docs#59716
Open
joshtrichards wants to merge 6 commits into
Open
fix(Color): blueF() to return correct channel and tighten validation/docs#59716joshtrichards wants to merge 6 commits into
joshtrichards wants to merge 6 commits into
Conversation
Member
Author
|
Aww, crap. Forgot to update+commit the autoloader change. I'll do it later when I can pull the branch down (unless someone else beats me to it). |
susnux
approved these changes
Apr 20, 2026
CarlSchwan
approved these changes
May 11, 2026
34ba348 to
54a7efb
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
See #32973 Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
54a7efb to
d123a38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
OCP\Color::blueF()to return the correct channel and cleans upOCP\Colorto make its API contract and behavior clearer.blueF()to return the blue - not green - channelmixPalette()andalphaBlending()docs so they match actual current behaviorNotes:
round()instead of rawinttruncation for better interpolation quality, but I didn't want to risk blindly introducing that change in this public APImixPalette()behavior is intentionally unchanged: it returns a list that starts with$color1and progresses toward$color2, excluding$color2(now documented accurately!)alphaBlending()behavior is intentionally unchanged; this change documents and validates the existing contractP.S. I spent an embarrassing amount of time on this tiny class. 😆
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)