Skip to content

chore!(core): remove deprecated Handlebars globals#59748

Merged
susnux merged 2 commits intomasterfrom
chore/remove-handlebars
Apr 24, 2026
Merged

chore!(core): remove deprecated Handlebars globals#59748
susnux merged 2 commits intomasterfrom
chore/remove-handlebars

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 20, 2026

Summary

Global Handlebars have been deprecated since Nextcloud 19. We do not use them anymore and all integrations were removed with Nextcloud 34. So its time to also remove the globals and thus the dependency.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added this to the Nextcloud 34 milestone Apr 20, 2026
@susnux susnux requested review from a team as code owners April 20, 2026 21:19
@susnux susnux added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Apr 20, 2026
@susnux susnux requested review from nfebe, sorbaugh and szaimen and removed request for a team April 20, 2026 21:19
@susnux susnux added the pending documentation This pull request needs an associated documentation update label Apr 20, 2026
@susnux susnux requested review from CarlSchwan and skjnldsv and removed request for a team April 20, 2026 21:19
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@joshtrichards joshtrichards force-pushed the chore/remove-handlebars branch from 9e84631 to f3b08e6 Compare April 23, 2026 23:53
@joshtrichards
Copy link
Copy Markdown
Member

/compile

susnux and others added 2 commits April 24, 2026 07:46
Global Handlebars have been deprecated since Nextcloud 19.
We do not use them anymore and all integrations were removed with
Nextcloud 34. So its time to also remove the globals and thus the
dependency.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the chore/remove-handlebars branch from 6025c88 to b993ce9 Compare April 24, 2026 05:46
@susnux susnux merged commit 8f9b11e into master Apr 24, 2026
131 checks passed
@susnux susnux deleted the chore/remove-handlebars branch April 24, 2026 15:00
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 24, 2026

documentation: nextcloud/documentation#14587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants