Skip to content

perf(share): Remove useless order by id#59753

Merged
CarlSchwan merged 4 commits into
masterfrom
work/carl/remove-orderById
May 13, 2026
Merged

perf(share): Remove useless order by id#59753
CarlSchwan merged 4 commits into
masterfrom
work/carl/remove-orderById

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

Summary

This should improve a bit the performance in some particular cases

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Comment thread lib/private/Share20/DefaultShareProvider.php Outdated
Comment thread lib/private/Share20/DefaultShareProvider.php Outdated
@CarlSchwan CarlSchwan marked this pull request as ready for review April 22, 2026 10:26
@CarlSchwan CarlSchwan requested a review from a team as a code owner April 22, 2026 10:26
@CarlSchwan CarlSchwan requested review from Altahrim, ArtificialOwl, leftybournes and sorbaugh and removed request for a team April 22, 2026 10:26
Comment thread lib/private/Share20/DefaultShareProvider.php
@nickvergessen
Copy link
Copy Markdown
Member

Failing unit tests proof my point 🙈

CarlSchwan and others added 2 commits May 7, 2026 19:16
This should improve a bit the performance in some particular cases

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@icewind1991 icewind1991 force-pushed the work/carl/remove-orderById branch from 36bbc1b to 0d79ac8 Compare May 7, 2026 17:19
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the work/carl/remove-orderById branch from 0d79ac8 to d307557 Compare May 8, 2026 16:05
@CarlSchwan CarlSchwan merged commit fcb956b into master May 13, 2026
230 of 249 checks passed
@CarlSchwan CarlSchwan deleted the work/carl/remove-orderById branch May 13, 2026 10:21
@CarlSchwan
Copy link
Copy Markdown
Member Author

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants