Wrap oauth2 token rotation in a transaction#59767
Merged
ChristophWurst merged 3 commits intomasterfrom Apr 23, 2026
Merged
Conversation
julien-nc
requested review from
CarlSchwan,
artonge,
leftybournes and
salmart-dev
and removed request for
a team
julien-nc
added
enhancement
3. to review
julien-nc
force-pushed
the
enh/noid/safer-oauth2-gettoken
branch
2 times, most recently
from
cfff43c to
694aeb0
Compare
ChristophWurst
approved these changes
Apr 21, 2026
Member
|
My only nitpick would be to change the commits to |
julien-nc
force-pushed
the
enh/noid/safer-oauth2-gettoken
branch
from
694aeb0 to
df22942
Compare
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
…token hasn't been modified since we have read it Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…as successful Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/safer-oauth2-gettoken
branch
from
df22942 to
59b3d7a
Compare
DorraJaouad
requested review from
mgallien,
miaulalala,
nickvergessen and
provokateurin
as code owners
DorraJaouad
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
miaulalala
approved these changes
Apr 23, 2026
This was referenced Apr 23, 2026
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap the token rotation in a transaction, only rotate if the access token hasn't been modified since we have read it.
If the access token has been modified, we invalidate the authentication token if needed and we rollback the db changes.
This logic applies to a code (when generating the first access token) or a refresh token (when refreshing an access token).
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)