feat: add ClientService configuration option#59768
Conversation
cb5cb2c to
1b6ab19
Compare
b4cc3dc to
877da2b
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
877da2b to
b658c38
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
b658c38 to
082c137
Compare
| interface IClientService { | ||
|
|
||
| /** | ||
| * @param array $baseConfig default configuration for the client |
There was a problem hiding this comment.
Which options are supported? If we merge something like that it will need proper documentation.
There was a problem hiding this comment.
In practice it would support whatever the GuzzleClient supports. Do you suggest documenting all the options for it?
There was a problem hiding this comment.
The point of this wrapper is to hide away Guzzle from apps so that they have a stable API they can use.
I’m not knowledgeable enough to understand whether these options are needed and which ones would be useful.
But either we list here options which are supported and we’ll have to work on keep supporting them (meaning even if Guzzle drops them), or we decide that it’s okay to rely on guzzle for this and we add a link to guzzle documentation to see what’s supported.
There was a problem hiding this comment.
For news it's these headers and config values: https://github.com/nextcloud/news/blob/master/lib/Config/FetcherConfig.php#L131-L146
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This will allow apps to request a client with a base configuration to match their needs. Making the service more widely usable.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)