Skip to content

feat: add ClientService configuration option#59768

Open
SMillerDev wants to merge 2 commits into
masterfrom
SMillerDev-patch-1
Open

feat: add ClientService configuration option#59768
SMillerDev wants to merge 2 commits into
masterfrom
SMillerDev-patch-1

Conversation

@SMillerDev
Copy link
Copy Markdown
Contributor

@SMillerDev SMillerDev commented Apr 21, 2026

  • Resolves: NONE

Summary

This will allow apps to request a client with a base configuration to match their needs. Making the service more widely usable.

TODO

  • implement the configuration
  • add tests

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SMillerDev SMillerDev requested a review from a team as a code owner April 21, 2026 08:44
@SMillerDev SMillerDev requested review from Altahrim, ArtificialOwl, icewind1991 and provokateurin and removed request for a team April 21, 2026 08:44
@SMillerDev SMillerDev marked this pull request as draft April 21, 2026 08:45
@SMillerDev SMillerDev marked this pull request as ready for review April 26, 2026 10:23
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
@SMillerDev SMillerDev added this to the Nextcloud 34 milestone Apr 26, 2026
@SMillerDev SMillerDev added the 3. to review Waiting for reviews label Apr 26, 2026
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
interface IClientService {

/**
* @param array $baseConfig default configuration for the client
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which options are supported? If we merge something like that it will need proper documentation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice it would support whatever the GuzzleClient supports. Do you suggest documenting all the options for it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this wrapper is to hide away Guzzle from apps so that they have a stable API they can use.
I’m not knowledgeable enough to understand whether these options are needed and which ones would be useful.

But either we list here options which are supported and we’ll have to work on keep supporting them (meaning even if Guzzle drops them), or we decide that it’s okay to rely on guzzle for this and we add a link to guzzle documentation to see what’s supported.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants