fix(files,files_sharing): swallow redirected navigation errors#59842
Merged
fix(files,files_sharing): swallow redirected navigation errors#59842
Conversation
susnux
approved these changes
Apr 22, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
/compile |
Member
Author
|
/backport e03bdbb to stable33 |
Member
Author
|
/backport e03bdbb to stable32 |
nfebe
approved these changes
Apr 23, 2026
DorraJaouad
requested review from
a team,
SebastianKrupinski,
hamza221,
mgallien,
miaulalala,
nickvergessen and
provokateurin
as code owners
miaulalala
previously requested changes
Apr 23, 2026
Contributor
miaulalala
left a comment
miaulalala
left a comment
There was a problem hiding this comment.
Seems some unrelated changes slipped in - l10n and workflow files.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
fix/swallow-redirected-navigation
branch
from
5e6d741 to
ed7223b
Compare
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ignoreDuplicateNavigationcatch wrappingRouter.prototype.push/replacein both routers only handledNavigationFailureType.duplicated.redirectedfailures, thrown when an in-flight navigation is short-circuited by a guard, fell through and surfaced as:in users' browser consoles. These failures still reach a valid view, so they should be treated the same as duplicated ones.
Reported via nextcloud/groupfolders#4499 and surfaced while reviewing nextcloud/groupfolders#4586.
Checklist
3. to review, feature component)stable32)AI (if applicable)