Skip to content

fix(files): do not show convert-file action in view-only shares#59850

Merged
susnux merged 2 commits intomasterfrom
fix/files-share-convert
Apr 22, 2026
Merged

fix(files): do not show convert-file action in view-only shares#59850
susnux merged 2 commits intomasterfrom
fix/files-share-convert

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 22, 2026

Summary

Ensure the convert-to files action is only shown if permissions are available.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from a team and skjnldsv as code owners April 22, 2026 15:22
@susnux susnux requested review from szaimen and removed request for a team April 22, 2026 15:22
@susnux susnux added the bug label Apr 22, 2026
@susnux susnux requested a review from sorbaugh April 22, 2026 15:22
@susnux susnux added 3. to review Waiting for reviews feature: files labels Apr 22, 2026
@susnux susnux requested a review from provokateurin April 22, 2026 15:22
@susnux susnux added this to the Nextcloud 34 milestone Apr 22, 2026
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 22, 2026

/backport to stable33

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 22, 2026

/backport to stable32

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@provokateurin
Copy link
Copy Markdown
Member

/compile

@provokateurin
Copy link
Copy Markdown
Member

/backport to stable33

@provokateurin
Copy link
Copy Markdown
Member

/backport to stable32

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 98f8536 into master Apr 22, 2026
141 of 144 checks passed
@susnux susnux deleted the fix/files-share-convert branch April 22, 2026 20:28
@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 22, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/59850/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 25fc2d8f 4e6e63b3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59850/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Copy Markdown
Member

/backport to stable32

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 23, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/59850/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 25fc2d8f 4e6e63b3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59850/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 23, 2026

/backport 25fc2d8 to stable32

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 23, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/59850/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 25fc2d8f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59850/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants