feat(settings): replace OnlyOffice with Euro-Office in office suite s…#59933
feat(settings): replace OnlyOffice with Euro-Office in office suite s…#59933moodyjmz wants to merge 4 commits into
Conversation
…witcher Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
moodyjmz
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
| { | ||
| id: 'onlyoffice', | ||
| id: 'euro-office', | ||
| appId: 'onlyoffice', |
There was a problem hiding this comment.
so this would technically be incorrect?
There was a problem hiding this comment.
yes, I've left it as a draft because I want to ask some questions
There was a problem hiding this comment.
It would rather be eurooffice according to the connector's appinfo.xml: https://github.com/Euro-Office/eurooffice-nextcloud/blob/main/appinfo/info.xml#L3
There was a problem hiding this comment.
But the app is not yet in the store so cannot be used like that afaik
|
@jospoortvliet @jancborchardt what do you think? |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Nice! :) I think:
- "Nextcloud Office" should be the left entry, default selected, but that would be the one powered by Euro-Office
- "Powered by Euro-Office" could be the first bullet point beneath that
- "Collabora Office" should be the right entry
That uses the same logic as before: The default is called "Nextcloud Office", whatever it’s powered by. The alternative uses its brand name.
…nding - Rename euro-office entry to 'Nextcloud Office' backed by eurooffice app - Add 'Powered by Euro-Office' as first feature bullet - Rename richdocuments entry to 'Collabora Office' - Reorder so Nextcloud Office is the primary (left) card Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…alled Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…logs OC.Notification.showTemporary no longer exists in NC34. Replace with showSuccess/showError from @nextcloud/dialogs. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
I have made these changes @elzody can you review this? |
5 participants
…witcher
Summary
Changes the OnlyOffice entry for Euro-Office
How to setup
Testing in the Euro-Office dev environment
Create a temporary
Dockerfile.nextcloudin your local checkout of the server branch root do not commit:FROM nextcloud:latest
COPY dist/settings-apps-view-4529.js /usr/src/nextcloud/dist/settings-apps-view-4529.js
COPY dist/settings-apps-view-4529.js.map /usr/src/nextcloud/dist/settings-apps-view-4529.js.map
Then in
develop/docker-compose.yml, temporarily replace:image: nextcloud:latest
with:
build:
context: /path/to/server
dockerfile: Dockerfile.nextcloud
Run docker compose build nextcloud && docker compose up -d --force-recreate nextcloud, then open http://localhost:8081/settings/apps/office.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)