fix(core): prompt for password once when installing recommended apps#60165
Open
pringelmann wants to merge 1 commit intomasterfrom
Open
fix(core): prompt for password once when installing recommended apps#60165pringelmann wants to merge 1 commit intomasterfrom
pringelmann wants to merge 1 commit intomasterfrom
Conversation
pringelmann
added
3. to review
pringelmann
requested review from
artonge,
come-nc,
nfebe,
susnux and
szaimen
and removed request for
a team
Contributor
|
/backport to stable33 |
Contributor
|
It will need backport to all versions the fix was backported to, sadly, but we can wait for the 33 backport first to watch for conflicts. |
Wire the password-confirmation interceptors into the recommendedapps entry point and switch the installer to a single bulk enable call so the strict password confirmation on enableApps is satisfied. Fixes #60068 -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Member
|
Maybe an opportunity to expand the test coverage a bit: server/cypress/e2e/core/setup.ts Line 114 in fb67d5d Perhaps an "Install failure / success flow" coverage path (using one of the smaller bundles)? |
pringelmann
force-pushed
the
fix/recommended-apps-password-confirmation
branch
from
37b46df to
8226b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the regression introduced in #59764 where the install assistant's "Install recommended apps" button always failed with unauthorized responses.
AppSettingsController::enableAppsnow requires strict password confirmation, but theRecommendedApps.vueinstaller was calling it via plainaxios.post(...)without theconfirmPasswordoption (and therecommendedapps.jsentry point hadn't registered the password-confirmation interceptors). The per-app loop is also collapsed into a single bulk call so the user is prompted once instead of N times.Checklist
3. to review, feature component)stable32)