fix(settings): Show loading spinner while searching accounts#60504
Open
nfebe wants to merge 1 commit into
Open
fix(settings): Show loading spinner while searching accounts#60504nfebe wants to merge 1 commit into
nfebe wants to merge 1 commit into
Conversation
Typing in the account search field briefly emptied the list and displayed "No accounts" until the request returned, which on large instances misled admins into thinking the query matched nothing. The empty-state now keeps the loading spinner visible whenever the list is empty and a fetch is in flight, regardless of whether it is the initial page load or a subsequent search/group switch. Signed-off-by: nfebe <fenn25.fn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing in the account search field briefly emptied the list and displayed "No accounts" until the request returned, which on large instances misled admins into thinking the query matched nothing. The empty-state now keeps the loading spinner visible whenever the list is empty and a fetch is in flight, regardless of whether it is the initial page load or a subsequent search/group switch.