Skip to content

[stable31] fix(comments): Add an action to comment notification that dismisses it#60523

Merged
nickvergessen merged 2 commits into
stable31from
backport/60150/stable31
May 20, 2026
Merged

[stable31] fix(comments): Add an action to comment notification that dismisses it#60523
nickvergessen merged 2 commits into
stable31from
backport/60150/stable31

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented May 19, 2026

Backport of PR #60150

Signed-off-by: Joas Schilling <coding@schilljs.com>
@backportbot backportbot Bot added bug 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. feature: comments labels May 19, 2026
@miaulalala miaulalala requested a review from janepie May 19, 2026 13:47
@miaulalala miaulalala force-pushed the backport/60150/stable31 branch from cf34408 to cff4e06 Compare May 19, 2026 14:45
@miaulalala
Copy link
Copy Markdown
Contributor

/compile amend

window.Buffer / Buffer is a Node.js API that is not natively available
in browsers. Replace with the native browser btoa() which has been
universally available since before our minimum browser support baseline.

Backport of #60148

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the backport/60150/stable31 branch from cff4e06 to f92bbba Compare May 19, 2026 23:48
@janepie
Copy link
Copy Markdown
Member

janepie commented May 20, 2026

Something's missing, the comment bubble doesn't disappear. I doublechecked on master, that one works

@nickvergessen nickvergessen merged commit 6d87a25 into stable31 May 20, 2026
178 of 188 checks passed
@nickvergessen nickvergessen deleted the backport/60150/stable31 branch May 20, 2026 08:20
@nickvergessen
Copy link
Copy Markdown
Member

Sorry saw the comment only afterwards. But it's totally unrelated to my change

@miaulalala
Copy link
Copy Markdown
Contributor

Something's missing, the comment bubble doesn't disappear. I doublechecked on master, that one works

might be the change in the activity app, I didn't backport that to 31 yet iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: comments papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants