fix(settings): clear NcAppNavigation toggle overhang#60596
Open
pringelmann wants to merge 1 commit into
Open
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
added
bug
design
pringelmann
requested review from
kra-mo,
nfebe,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
NcAppNavigationTogglebutton overlaps the start of section content on Nextcloud settings pages. Adds an inline-start offset to settings sections and the personal-info grid so content clears the toggle.Companion lib PR handles the Vue 3
NcSettingsSection, which has a different box model.🖼️ Screenshots
TODO
Checklist
stable34where theNcAppNavigationmigration landed