Skip to content

[stable32] fix(comments): mark comments as read and dismiss notifications in Activity sidebar#60622

Open
miaulalala wants to merge 1 commit into
stable32from
backport/60617/stable32
Open

[stable32] fix(comments): mark comments as read and dismiss notifications in Activity sidebar#60622
miaulalala wants to merge 1 commit into
stable32from
backport/60617/stable32

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

Backport of #60617 to stable32.

Summary

  • When the Activity app integration is active, comments load in the Activity sidebar instead of the Comments tab
  • markCommentsAsRead() and mention notification dismissal were never called in this code path
  • This left the unread bubble (💬) in the file list and kept mention notifications active
  • Adds a new DELETE /notifications/{id} endpoint to dismiss individual mention notifications by comment ID

Test plan

  • Enable the Activity app
  • Have another user mention you in a file comment
  • Open the file's Activity sidebar — the unread bubble should disappear after viewing
  • Check that the mention notification is dismissed

🤖 Generated with Claude Code

@miaulalala miaulalala requested review from a team as code owners May 20, 2026 16:25
@miaulalala miaulalala requested review from ArtificialOwl, leftybournes, nfebe, sorbaugh and susnux and removed request for a team May 20, 2026 16:25
@miaulalala miaulalala changed the title fix(comments): mark comments as read and dismiss notifications in Activity sidebar [stable32] [stable32] fix(comments): mark comments as read and dismiss notifications in Activity sidebar May 20, 2026
@miaulalala miaulalala self-assigned this May 20, 2026
@miaulalala miaulalala added this to the Nextcloud 32.0.10 milestone May 20, 2026
@miaulalala miaulalala requested a review from janepie May 20, 2026 16:27
@miaulalala miaulalala force-pushed the backport/60617/stable32 branch from 6866267 to a89e9aa Compare May 20, 2026 16:31
…ivity sidebar

Backport of #60617 to stable32.

When the Activity app integration is active, comments are loaded in the
Activity sidebar instead of the Comments tab. The read marker and mention
notification dismissal were never triggered in this path, leaving the
unread bubble in the file list and keeping mention notifications active.

Also adds a new DELETE /notifications/{id} endpoint to dismiss individual
mention notifications by comment ID.

AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the backport/60617/stable32 branch from a89e9aa to 4aac879 Compare May 20, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants