refactor(auth): clarify 2FA state handling in TwoFactorAuth Manager#60736
Draft
joshtrichards wants to merge 11 commits into
Draft
refactor(auth): clarify 2FA state handling in TwoFactorAuth Manager#60736joshtrichards wants to merge 11 commits into
joshtrichards wants to merge 11 commits into
Conversation
…ted() Signed-off-by: Josh <josh.t.richards@gmail.com>
…ctions Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…into helpers Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…actorLogin() Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…orPending overlap - Refactor overlap - Clarify separate concerns - Re-order together within class Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
2. developing
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
TwoFactorAuth\Managerto make 2FA login-state handling more explicit and maintainable.Changes
needsSecondFactor()with dedicated helpers for pending, satisfied, and stale stateverifyChallenge()login_token_2faconfig keyMotivation
This keeps the existing flow easier to reason about and prepares the class for future cleanup around explicit 2FA state tracking. i.e. #39411
Checklist
3. to review, feature component)stable32)AI (if applicable)