fix(core): Hide current-app label at narrower viewports#60757
Conversation
|
/backport to stable34 |
| // truncation cap as a safety net for long localized names. | ||
| display: none; | ||
|
|
||
| @media only screen and (min-width: 1400px) { |
There was a problem hiding this comment.
Any reason for that breaking point? Its different from the normal ones we have (e.g. 1024)
There was a problem hiding this comment.
1400 is a stopgap. The deeper issue is that the centered search in #60665 is absolutely positioned, so CSS can't shrink the trigger label against available space. The choices are a static cap (this), a ResizeObserver, or restructuring the header so the trigger and search are flex siblings and the label can shrink/truncate naturally.
This happens to be the viewport where, at the search's max width, the abs search bar shouldn't visually collide with realistic trigger widths. (e.g. Appearance and accessibility)
The flex restructure is the proper fix but this work needs to be merged asap. I have made a note to follow up on this post-release (along with all the other deferred waffle menu improvements)
5215309 to
6352449
Compare
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
6352449 to
a210455
Compare
Summary
Preview url: https://nc-preview.tail22c02b.ts.net/
Long section names like "Appearance and accessibility" in admin areas could push the current-app trigger past the header. The existing
max-widthcap never fires in practice; realistic labels stay well under it. Hide the label by default and restore it at ≥ 1400px where the layout has room, with a tighter truncation cap as a safety net for long localized names.In future we should consider making this robust by adding all header items to the same flex container.
Checklist
3. to review, feature component)stable32)