Skip to content

fix(core): Hide current-app label at narrower viewports#60757

Merged
sorbaugh merged 2 commits into
masterfrom
fix/59888-current-app-label-responsive
May 27, 2026
Merged

fix(core): Hide current-app label at narrower viewports#60757
sorbaugh merged 2 commits into
masterfrom
fix/59888-current-app-label-responsive

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

@pringelmann pringelmann commented May 27, 2026

Summary

Preview url: https://nc-preview.tail22c02b.ts.net/

Long section names like "Appearance and accessibility" in admin areas could push the current-app trigger past the header. The existing max-width cap never fires in practice; realistic labels stay well under it. Hide the label by default and restore it at ≥ 1400px where the layout has room, with a tighter truncation cap as a safety net for long localized names.

In future we should consider making this robust by adding all header items to the same flex container.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

@pringelmann pringelmann added this to the Nextcloud 34 milestone May 27, 2026
@pringelmann pringelmann self-assigned this May 27, 2026
@pringelmann pringelmann added design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 27, 2026
@pringelmann pringelmann marked this pull request as ready for review May 27, 2026 08:33
@pringelmann pringelmann requested a review from a team as a code owner May 27, 2026 08:33
@pringelmann pringelmann requested review from nfebe, sorbaugh and susnux and removed request for a team May 27, 2026 08:33
@pringelmann
Copy link
Copy Markdown
Contributor Author

/backport to stable34

// truncation cap as a safety net for long localized names.
display: none;

@media only screen and (min-width: 1400px) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for that breaking point? Its different from the normal ones we have (e.g. 1024)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1400 is a stopgap. The deeper issue is that the centered search in #60665 is absolutely positioned, so CSS can't shrink the trigger label against available space. The choices are a static cap (this), a ResizeObserver, or restructuring the header so the trigger and search are flex siblings and the label can shrink/truncate naturally.

This happens to be the viewport where, at the search's max width, the abs search bar shouldn't visually collide with realistic trigger widths. (e.g. Appearance and accessibility)

The flex restructure is the proper fix but this work needs to be merged asap. I have made a note to follow up on this post-release (along with all the other deferred waffle menu improvements)

@pringelmann pringelmann force-pushed the fix/59888-current-app-label-responsive branch from 5215309 to 6352449 Compare May 27, 2026 09:55
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the fix/59888-current-app-label-responsive branch from 6352449 to a210455 Compare May 27, 2026 13:55
@sorbaugh sorbaugh merged commit e753718 into master May 27, 2026
124 of 128 checks passed
@sorbaugh sorbaugh deleted the fix/59888-current-app-label-responsive branch May 27, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Navigation Redesign

3 participants