test(behat): reset per-scenario state in BasicStructure and Sharing#60763
Merged
Conversation
miaulalala
requested review from
Altahrim,
artonge,
icewind1991 and
salmart-dev
and removed request for
a team
Contributor
Author
|
/backport to stable34 |
miaulalala
added
tests
blizzz
approved these changes
May 27, 2026
CarlSchwan
approved these changes
May 27, 2026
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
First, thanks for digging into and fixing these! These various test flakiness issues are frustrating and highly worthwhile to sort out. Just a tiny completeness matter regarding $this->baseUrl. The other longer bit of feedback is based on some thinking about a possible overall "tighter" structure... to help prevent these sort of issues from cropping up going forward while preventing source of truth / code sprawl.
miaulalala
force-pushed
the
fix/noid/behat-scenario-state-isolation
branch
from
3c4141c to
201dc9a
Compare
miaulalala
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
Add @BeforeScenario hooks to reset auth/server state and sharing state between scenarios, preventing state bleed across test runs. - BasicStructure: reset currentUser, currentServer, baseUrl, apiVersion, requestToken and cookieJar (baseUrl and currentServer go together via usingServer(), so both must be reset) - Sharing: reset lastShareData, storedShareData and savedShareId Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
force-pushed
the
fix/noid/behat-scenario-state-isolation
branch
from
201dc9a to
d58e55a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$currentUser,$currentServer,$apiVersion,$requestToken, and$cookieJarinBasicStructure.phpwere never reset between scenarios — a scenario could silently inherit auth context from the previous one$lastShareData,$storedShareData, and$savedShareIdinSharing.phpwere never reset — 12 methods read$lastShareDatawhich could carry stale data from a previous scenarioAdds
@BeforeScenariohooks to both traits to reset these to clean defaults at the start of each scenario.Safety
Verified that every scenario in the integration test suite which reads
$lastShareData(via steps like "Getting info of last share", "Deleting last share", "accepting last share") also creates a share earlier in that same scenario. Thesave/restorepattern (storedShareData) is always used within a single scenario boundary. No cross-scenario data dependencies exist.Test plan
sharing_features,filesdrop_features,files_featureswhich make heaviest use of the sharing steps🤖 Generated with Claude Code