Skip to content

fix(Storage): use proxyexclude parameter in DAV client#60787

Merged
susnux merged 3 commits into
masterfrom
jtr/fix-storage-dav-client-proxyexclude
Jun 2, 2026
Merged

fix(Storage): use proxyexclude parameter in DAV client#60787
susnux merged 3 commits into
masterfrom
jtr/fix-storage-dav-client-proxyexclude

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards commented May 27, 2026

Summary

The DAV backend uses Sabre \DAV\Client rather than our Guzzle wrapper. This adds support for the proxyexclude directive to the Sabre client.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@joshtrichards
Copy link
Copy Markdown
Member Author

joshtrichards commented May 27, 2026

/backport to stable34

@joshtrichards
Copy link
Copy Markdown
Member Author

joshtrichards commented May 27, 2026

/backport to stable33

@joshtrichards joshtrichards marked this pull request as ready for review May 27, 2026 21:14
@joshtrichards joshtrichards requested a review from a team as a code owner May 27, 2026 21:14
@joshtrichards joshtrichards requested review from ArtificialOwl, come-nc, leftybournes and provokateurin and removed request for a team May 27, 2026 21:15
@joshtrichards joshtrichards mentioned this pull request May 27, 2026
Closed
8 tasks
provokateurin
provokateurin approved these changes May 28, 2026
View reviewed changes
Comment thread lib/private/Files/Storage/DAV.php Outdated
@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 28, 2026
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone May 28, 2026
joshtrichards and others added 3 commits May 29, 2026 11:41
@joshtrichards
fix(Storage): use proxyexclude parameter in DAV client
2771543 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore(DAV): fixup for lint
d68a7f0 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards @provokateurin
chore(DAV): fixup proxyexclude default value check
a494fcd 
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards force-pushed the jtr/fix-storage-dav-client-proxyexclude branch from 1253151 to a494fcd Compare May 29, 2026 15:41
@susnux susnux merged commit ce3b3b7 into master Jun 2, 2026
215 of 231 checks passed
@susnux susnux deleted the jtr/fix-storage-dav-client-proxyexclude branch June 2, 2026 16:02
This was referenced Jun 2, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: dav feature: external storage

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: External storage app ignoring proxyexclude

4 participants

@joshtrichards @CarlSchwan @provokateurin @susnux