Skip to content

feat(search): Subdue header search input placeholder#60813

Merged
AndyScherzinger merged 2 commits into
masterfrom
feat/nav-redesign-search-placeholder-contrast
May 29, 2026
Merged

feat(search): Subdue header search input placeholder#60813
AndyScherzinger merged 2 commits into
masterfrom
feat/nav-redesign-search-placeholder-contrast

Conversation

@nfebe
Copy link
Copy Markdown
Contributor

@nfebe nfebe commented May 28, 2026

The header search placeholder now reads as a hint rather than competing visually with the icon and surrounding header items.

Before After
before-search after-search

Refs: #59888

@nfebe nfebe requested a review from jancborchardt May 28, 2026 14:01
@nfebe nfebe requested a review from a team as a code owner May 28, 2026 14:02
@nfebe nfebe requested review from skjnldsv, sorbaugh and susnux and removed request for a team May 28, 2026 14:02
Copy link
Copy Markdown
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! :)

@jancborchardt jancborchardt requested a review from kra-mo May 28, 2026 15:19
@jancborchardt jancborchardt added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: search labels May 28, 2026
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team May 28, 2026
@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented May 28, 2026

/compile

@nfebe nfebe force-pushed the feat/nav-redesign-search-placeholder-contrast branch from 08206d2 to 5b1465d Compare May 28, 2026 16:57
@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented May 28, 2026

/backport to stable34

The header search placeholder now reads as a hint rather than
competing visually with the icon and surrounding header items.

Refs: #59888
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/nav-redesign-search-placeholder-contrast branch from 5b1465d to 6b6f129 Compare May 28, 2026 19:20
@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented May 28, 2026

/compile

Copy link
Copy Markdown
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice !!

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 35 milestone May 29, 2026
@AndyScherzinger AndyScherzinger merged commit 8f65f63 into master May 29, 2026
145 of 154 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/nav-redesign-search-placeholder-contrast branch May 29, 2026 10:27
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: search

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

6 participants