fix(preview): First cleanup from filecache and then from preview table#61011
Merged
Conversation
CarlSchwan
requested review from
artonge,
leftybournes and
salmart-dev
and removed request for
a team
8 tasks
artonge
approved these changes
Jun 5, 2026
CarlSchwan
force-pushed
the
carl/cleanup-preview
branch
3 times, most recently
from
36e4290 to
701a03c
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Now the logic is inverted so the tests need to be changed Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/cleanup-preview
branch
from
701a03c to
acfe107
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
|
Thanks for working on this bug, let me know if you want me to try on my instance 👍 |
susnux
approved these changes
Jun 22, 2026
CarlSchwan
force-pushed
the
carl/cleanup-preview
branch
2 times, most recently
from
b106cdd to
76a6b0c
Compare
If we don't find previews in the filecache, this is now normal. Don't abort and instead delete previews from the new preview table instead. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/cleanup-preview
branch
from
76a6b0c to
09aea63
Compare
Member
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)