fix(NavigationManager): resolve entries only when needed#61055
Open
susnux wants to merge 2 commits into
Open
Conversation
susnux
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
requested review from
artonge and
leftybournes
and removed request for
a team
The `init` method previously contained two different logics: 1. It set up the internal state of default apps and app order 2. It resolved the app navigation entries The 1. is needed before `add` can be called, so it was always called by the `add` method, but this also resolved all appinfo.xml entries on the first `add` call even if never used. The 2. is only needed when the navigations are actually fetched. This splits the logic into two functions: - `init` for the bare initialization - `resolveAppNavigationEntries` for resolving the entries when requesting to output them. This should give a small performance improvement for API calls and fixes a problem when navigations are added before all apps are registered. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
initmethod previously contained two different logics:The 1. is needed before
addcan be called, so it was always called by theaddmethod, but this also resolved all appinfo.xml entries on the firstaddcall even if never used.The 2. is only needed when the navigations are actually fetched.
This splits the logic into two functions:
initfor the bare initializationresolveAppNavigationEntriesfor resolving the entries when requesting to output them.This should give a small performance improvement for API calls and fixes a problem when navigations are added before all apps are registered.
Checklist
3. to review, feature component)stable32)AI (if applicable)