fix(files_external): Allow editing auth mechanism on saved mounts#61312
Merged
Conversation
nfebe
force-pushed
the
fix/files-external-edit-auth-mechanism
branch
2 times, most recently
from
260dce5 to
2e66d5b
Compare
susnux
approved these changes
Jun 21, 2026
pringelmann
approved these changes
Jun 22, 2026
Restores the pre-33 behaviour where admins can change the authentication mechanism of an existing external storage mount through the settings UI. After the External Storage settings rewrite the dropdown was locked read-only for any mount with an id, leaving the value configured at creation time as the only one ever shown. Backend type stays locked because changing it would invalidate the mount; authentication mechanism is independent and was always meant to remain editable. Switching the mechanism now also clears the previously stored options that the newly selected mechanism does not use, so stale credentials are no longer kept in the saved configuration. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Contributor
|
/compile |
susnux
force-pushed
the
fix/files-external-edit-auth-mechanism
branch
from
2e66d5b to
d5905ac
Compare
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Contributor
|
/backport to stable34 |
Contributor
|
/backport to stable33 |
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the pre-33 behaviour where admins can change the authentication mechanism of an existing external storage mount through the settings UI. After the External Storage settings rewrite the dropdown was locked read-only for any mount with an id, leaving the value configured at creation time as the only one ever shown. Backend type stays locked because changing it would invalidate the mount; authentication mechanism is independent and was always meant to remain editable.