#61609: newly created folder gets downloaded #61610
Open
samin-z wants to merge 1 commit into
Open
Conversation
samin-z
commented
Jun 26, 2026
samin-z
commented
- Resolves: Stable 32: newly created folder gets downloaded #61609
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
susnux
reviewed
Jun 26, 2026
Contributor
There was a problem hiding this comment.
This looks unrelated and rather a UI feature that must go to master first
susnux
requested changes
Jun 26, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
This does not match the library version for Nextcloud 32.
Only in Nextcloud 34 the action format was changed (as we updated to v4 of the library)
| @@ -243,7 +277,7 @@ export default defineComponent({ | |||
| // In case something goes wrong, since we don't want to break | |||
| // the entire list, we filter out actions that throw an error. | |||
| try { | |||
| return action.enabled([this.source], this.currentView) | |||
| return (action.enabled as (context: FileActionContext) => boolean)(this.fileActionContext) | |||
Contributor
There was a problem hiding this comment.
No stable32 uses nextcloud-files v3 and there the format for enabled is:
Author
There was a problem hiding this comment.
thank you for the comments @susnux
i'll update accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.