fix(CalDav): Force trashbin deletion when re-creating item with same UID#61881
Merged
Conversation
DerDreschner
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
DerDreschner
added
3. to review
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
SebastianKrupinski
approved these changes
Jul 7, 2026
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
fix/force-trashbin-deletion
branch
from
0317bbf to
f6caf5a
Compare
ChristophWurst
approved these changes
Jul 7, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a calendar event is being deleted, but re-imported later on, the import currently fails as the trash-bin item isn't actually being deleted. That's fixed with this PR and a test to validate it is being added as well.
Checklist
3. to review, feature component)stable32)AI (if applicable)