Add meta information to emails for better customisation #6255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
MorrisJobke
requested changes
Aug 26, 2017
| $initiator, | ||
| $shareWith) { | ||
| $shareWith, | ||
| \DateTime $expiration) { |
Member
There was a problem hiding this comment.
Should be allowed to be set to null otherwise shares without an expiration date will fail with:
TypeError: Argument 5 passed to OCA\\ShareByMail\\ShareByMailProvider::sendMailNotification() must be an instance of DateTime, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 351 at apps/sharebymail/lib/ShareByMailProvider.php#376
Member
Author
There was a problem hiding this comment.
\DateTime $expiration = null is better?
Codecov Report
@@ Coverage Diff @@
## master #6255 +/- ##
=============================================
- Coverage 53.33% 30.54% -22.79%
Complexity 22480 22480
=============================================
Files 1403 1403
Lines 86955 86964 +9
Branches 1327 1327
=============================================
- Hits 46377 26566 -19811
- Misses 40578 60398 +19820
|
MorrisJobke
approved these changes
Aug 26, 2017
MorrisJobke
requested review from
ChristophWurst,
LukasReschke,
icewind1991,
oparoz and
rullzer
icewind1991
approved these changes
Aug 26, 2017
MorrisJobke
added
4. to release
rullzer
added
2. developing
Member
|
Failing tests |
MorrisJobke
force-pushed
the
email-meta-data
branch
from
80edcd8 to
f0c34a3
Compare
Member
Fixed |
MorrisJobke
added
4. to release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This was referenced Aug 28, 2017
This was referenced Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com