Fix quota calculation on new dav upload endpoint #6483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @DeepDiver1975 and @PVince81 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #6483 +/- ##
============================================
- Coverage 53.42% 53.42% -0.01%
- Complexity 22522 22529 +7
============================================
Files 1407 1407
Lines 87141 87160 +19
Branches 1328 1328
============================================
+ Hits 46557 46563 +6
- Misses 40584 40597 +13
|
rullzer
force-pushed
the
fix_quota_new_endpoint
branch
from
d34ed8a to
f97e654
Compare
icewind1991
approved these changes
Sep 13, 2017
Member
|
Do we have a way to get the target location of the upload before the client does the move? Would be nice to be able to check the quote when uploading the chunks instead of having the client upload all the chunks only to fail in the end. |
Member
Author
|
No we don't |
Member
|
Maybe adding a "Destination" header to the client would be something to do "some day™" |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix_quota_new_endpoint
branch
from
ddb9051 to
ab63c89
Compare
rullzer
added
3. to review
Member
Author
|
@icewind1991 yeah some day |
This was referenced Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6354
Should fix the QuotaPlugin for the new dav endpoint